Skip to content

Conversation

@wangzhi16
Copy link
Contributor

@wangzhi16 wangzhi16 commented Jan 21, 2026

Summary

This PR renames the non-instrumented critical-section API identifiers from the _wo_note suffix to _notrace to more clearly indicate the absence of tracing/notes. The change is a symbol rename and macro-update only; it does not alter runtime logic.

Details:

  • Replace enter_critical_section_wo_note() -> enter_critical_section_notrace()
  • Replace leave_critical_section_wo_note(flags) -> leave_critical_section_notrace(flags)
  • Update include/nuttx/irq.h to map enter_critical_section()/leave_critical_section() to _notrace variants when instrumentation is disabled.
  • Update implementation names and internal calls in sched/irq/irq_csection.c.
  • Update call sites in drivers/note/note_driver.c, sched/sched/sched_lock.c, and sched/sched/sched_unlock.c.

Impact

  • Users: Minimal functional impact; behaviour unchanged when all references are updated. External modules referencing the old _wo_note symbols will fail to link until updated.
  • Build: In-tree builds should succeed if all occurrences were updated; third-party code that references _wo_note will break.
  • Hardware: No hardware-specific changes.
  • Documentation: References to _wo_note should be updated.
  • Security: None.
  • Compatibility: API-level rename; consider adding deprecated compatibility macros if downstream stability is desired.

Testing

ostest PASS

@wangzhi16 wangzhi16 changed the title sched/sched: Modify the critical section interface name of the non-in… sched/sched: Modify the critical section interface name Jan 21, 2026
@github-actions github-actions bot added Area: Drivers Drivers issues Area: OS Components OS Components issues Size: S The size of the change in this PR is small labels Jan 21, 2026
Copy link
Contributor

@hujun260 hujun260 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image need change

replace _wo_note to _notrace.

Signed-off-by: wangzhi16 <wangzhi16@xiaomi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Drivers Drivers issues Area: OS Components OS Components issues Size: S The size of the change in this PR is small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants