rp2040,rp23xx,rp23xx-rv: allow up to 32 PIO instructions

[sumpfralle]

Summary

Previously only up to 31 PIO instructions were accepted. But the hardware allowed 32 instructions.

Now we accept 32 instructions.

See the corresponding commit in the pico-sdk repository.

Impact

Calling rp2040_pio_add_program with a PIO program containing 32 instructions previously ended in a panic state (DEBUGPANIC).

Now 32 instructions are accepted.

Testing

Uploading my application with 32 PIO instructions previously froze the device (rp2040).

Now uploading 32 PIO instructions succeeds.

No further testing was conducted with rp23xx or rp23xx-rv devices.
But the upstream code (pico-sdk) uses the same assert for all three device groups. Thus, the change should be suitable for all platforms.

[acassis]

@sumpfralle I found an issue this weekend when I compiled the raspberrypi-pico board without exporting PICO_SDK_PATH. The compilation went fine, but the final binary doesn't start the board.

In the past the build-system stops when PICO_SDK_PATH is not defined, but seems like someone remove the needs for it, but now the binary doesn't work. Exporting the PICO_SDK_PATH and compiling again fixes the issue.

Did you notice this issue?

[simbit18]

Hi @acassis , does this also occur with CMake?

perhaps it is related to this change here #16855
https://github.com/apache/nuttx/blob/master/tools/rp2040/Config.mk

[acassis]

Hi @acassis , does this also occur with CMake?

No idea, I didn't try CMake, but I can try now and let you know

[acassis]

Hi @acassis , does this also occur with CMake?

No idea, I didn't try CMake, but I can try now and let you know

CMake is not working here:

$ cmake -B build -DBOARD_CONFIG=raspberrypi-pico:usbnsh -GNinja
CMake Error at CMakeLists.txt:96 (message):
Kconfig environment depends on kconfiglib, Please install:

(APT source)
  $ sudo apt install python3-kconfiglib
or (pip source)
  $ pip install kconfiglib
or (After Ubuntu 24.04)
  $ pip install kconfiglib --break-system-packages

$ sudo apt install python3-kconfiglib
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
python3-kconfiglib is already the newest version (14.1.0-3).

[simbit18]

(APT source)
  $ sudo apt install python3-kconfiglib
or (pip source)
  $ pip install kconfiglib
or (After Ubuntu 24.04)
  $ pip install kconfiglib --break-system-packages

Hi @acassis , but that's another problem :)

remove

sudo apt remove package_name

try with pip

pip install kconfiglib

[acassis]

(APT source)
  $ sudo apt install python3-kconfiglib
or (pip source)
  $ pip install kconfiglib
or (After Ubuntu 24.04)
  $ pip install kconfiglib --break-system-packages

Hi @acassis , but that's another problem :)

Yes, seems like the build system is not detecting that python3-kconfiglib is installed in my system (Ubuntu 24.04)

[cederom]

Thank you @sumpfralle :-)

[acassis]

@simbit18 in the CMake the issue doesn't happen because it is detecting that the export is missing:

CMake Error at arch/arm/src/rp2040/CMakeLists.txt:100 (message):
PICO_SDK_PATH environment variable is not set. Please set it to the path
of your Pico SDK installation.

It is a regression in the Makefile build system, it was working in the past

[acassis]

I opened an issue to track it: #17516

[cederom]

I noticed that too some time ago but thought it was issue on my end, thanks @acassis !! :-)

[acassis]

I noticed that too some time ago but thought it was issue on my end, thanks @acassis !! :-)

Yes, initially I thought someone broke the mainline, then I compiled with the export and everything worked fine.

Actually it should be nice to have raspberrypi-pico working without needing the SDK. NuttX needs to work without attachments!