NUTCH-3164 Catch specific exceptions in CrawlDbFilter so plugin errors no longer silently drop URLs#918
Open
prakharchaube wants to merge 1 commit into
Open
NUTCH-3164 Catch specific exceptions in CrawlDbFilter so plugin errors no longer silently drop URLs#918prakharchaube wants to merge 1 commit into
prakharchaube wants to merge 1 commit into
Conversation
…s no longer silently drop URLs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both catch blocks in
CrawlDbFilter.map()caught genericExceptionand seturl = null, which silently dropped URLs both for legitimate filtering reasons and for pluginprogramming errors (NPE, etc.). The latter masked plugin bugs as ordinary filtering decisions.
Changes
Normalizer block
MalformedURLException— the only legitimate reason to drop. Tracked viaErrorTracker(ErrorType.URL) and no longer incrementsurlsFilteredCounter, which conflatedfiltering with malformed input.
RuntimeException— logged at ERROR and tracked, URL is not dropped so plugin bugs do not silently delete data.Filter block
URLFilterException— per theURLFiltercontract, reserved for internal filter failures (rejection is signaled by returningnull). Logged at ERROR and tracked, URL isnot dropped.
RuntimeException— same handling as above.All error paths now use
ErrorTrackerfor categorized counters and log at ERROR rather than WARN, per @lewismc's recommendation in the JIRAdiscussion.
JIRA
NUTCH-3164
Test plan
ant compilepasses locallyOut of scope (separate tickets if desired)
catch (Exception)pattern exists inInjector.filterNormalizeand ~20 other call sites ofnormalizers.normalize/filters.filter— per lewismc comment, thoseshould be rolled out separately.