NUTCH-3150 Expand Caching Hadoop Counter References#892
Merged
lewismc merged 1 commit intoapache:masterfrom Feb 10, 2026
Merged
NUTCH-3150 Expand Caching Hadoop Counter References#892lewismc merged 1 commit intoapache:masterfrom
lewismc merged 1 commit intoapache:masterfrom
Conversation
sebastian-nagel
approved these changes
Feb 10, 2026
Contributor
sebastian-nagel
left a comment
sebastian-nagel
left a comment
There was a problem hiding this comment.
Looks good to me.
Run several Nutch tools in local and pseudo-distributed mode to validate for potential issues.
Member
Author
|
Thanks @sebastian-nagel for review. |
sebastian-nagel
pushed a commit
to commoncrawl/nutch
that referenced
this pull request
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for NUTCH-3150 which Implements comprehensive counter caching optimization across all MapReduce jobs to eliminate repeated
context.getCounter()lookups in hot paths.Breaking this PR down...
initCounters(Context context)pattern which I think improves code interpretation aallowing for more intuitive future development around metrics. I saw @igiguere evolving metrics counters in NUTCH-1732: allow deleting non-parsable documents #891 which is excellent :)DomainStatistics.javafrom custom enum to NutchMetrics constants with cached counters.initCounters()methods for consistency across:... the metrics journey continues.
EDIT: I'll add that I'm absolutely fine with this NOT being included in 1.22. I plan to continue evolving Nutch metrics in 1.23 development drive.