Propagate canUseRelease into CustomJavacClassLoader#9383
Propagate canUseRelease into CustomJavacClassLoader#9383jtulach wants to merge 1 commit intoapache:deliveryfrom
Conversation
|
|
I know @ebarboni planned to run the release vote this week. This isn't currently labelled |
Thank you Neil. No reason to require additional RC and have a week delay because of this change. If there is some other "high" or "critical" reason for another RC, then we could include this PR. Otherwise, we just integrate it into |
matthiasblaesing
left a comment
There was a problem hiding this comment.
Looks sane to me and can IMHO be merged to master, not delivery. I don't see a reason to interfere with release for this.
Independent from that I disagree with the assessment, that having the magic --target == --source maps to --release in there is a good idea. Many modules are already are correctly configured in their properties, to use javac.release, it would be better to complete the transition there instead of this magic.
lahodaj
left a comment
There was a problem hiding this comment.
Looks OK to me. We can cleanup later when we stop using javac.source in NB.
canUseReleaseflag also in custom class loaderjava/formbuilds OK with the nb-javac being developed at 1:1 semantics withDirectModuleWrapperoverjava.lang.ModuleJaroslavTulach/nb-javac#39delivery:java/formmodule fromrelease300buildable by nb-javac