Fix #9337 — recognize compact -T<n> and --threads=<n> Maven flags#9382
Open
xerno wants to merge 1 commit intoapache:masterfrom
Open
Fix #9337 — recognize compact -T<n> and --threads=<n> Maven flags#9382xerno wants to merge 1 commit intoapache:masterfrom
xerno wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NetBeans only detected the spaced forms (
-T 2,--threads 2) as parallel builds. The compact forms (-T2) and GNU-style equals form (--threads=2) were not recognized, so for multi-module projects NetBeans kept its output tree-folding active and crashed with an NPE inCommandLineOutputHandler.trimTreewhen concurrent module events arrived (Cannot read field "type" because "start" is null).Extracts a
threadsArgValue()helper that recognizes all four forms and uses it from bothisMultiThreadedMavenandisMultiThreadedMvnd.Side effects, both intentional improvements
-T1now correctly flips to single-threaded mode (previously only the spaced-T 1did).-T(e.g.-Tfoo) is now reported as the threads value verbatim; Maven itself rejects such input.Tests
Added cases for
-T2,-T10,-T1C,-T1,--threads=2,--threads=1, and a dangling-Tto bothMavenCommandParametersAnalyzerTestandMavenDaemonCommandParametersAnalyzerTest.^Add meaningful description above
Click to collapse/expand PR instructions
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
PR approval and merge checklist:
If this PR targets the delivery branch: don't merge. (full wiki article)