make jnlp build process runnable again#9317
Conversation
| <javaresource classpath="${cp.extra}" name="com/sun/jdi/Bootstrap.class"/> | ||
| <javaresource classpath="${cp.extra}" name="com/sun/jdi/StackFrame.class"/> | ||
| <javaresource classpath="${cp.extra}" name="com/sun/jdi/ObjectReference.class"/> | ||
| <javaresource classpath="${cp.extra}" name="com/sun/jdi/ThreadReference.class"/> |
There was a problem hiding this comment.
I have no clue, why I need to use classpath="${cp.extra}" to make it work
|
do we know if a minimal platform app would still start using webstart? with the JDK removing (I have nothing against fixing it if its not that much work and do a few releases with it fixed) |
matthiasblaesing
left a comment
There was a problem hiding this comment.
The changes to the verify make sense to me. I read the code of the ant task as that the verification steps ensures, that all files found after build are actually used. This indeed would need someone with interest in the modules and JNLP interest to verify, but at least it gets the modules in a state of builability.
The signature and key algorithm changes makes sense to me.
The changes to the java/api.debugger.jpda and java.spi.debugger.jpda.ui modules make no sense right now as build-init is invoked on normal builds and so my question is: how can the problem be reproduced?
kind of the opposite of #9312
I do not remember if it was possible to generate a NetBeans jnlp back in the day.
ant build-jnlpbuild only the different modulesthis seems to work to rebuild jnlp files. this is quite long (20minutes)
the sha1 is not working anymore so need a bump to sha256
jnlp.verify.exclusion updated to match what ant warns about.
Some late verification like this one are failling (jarsigner also say so):