Skip to content

make jnlp build process runnable again#9317

Open
ebarboni wants to merge 1 commit intoapache:masterfrom
ebarboni:jnlpfix
Open

make jnlp build process runnable again#9317
ebarboni wants to merge 1 commit intoapache:masterfrom
ebarboni:jnlpfix

Conversation

@ebarboni
Copy link
Copy Markdown
Contributor

@ebarboni ebarboni commented Apr 1, 2026

kind of the opposite of #9312

I do not remember if it was possible to generate a NetBeans jnlp back in the day.
ant build-jnlp build only the different modules

this seems to work to rebuild jnlp files. this is quite long (20minutes)

the sha1 is not working anymore so need a bump to sha256
jnlp.verify.exclusion updated to match what ant warns about.

Some late verification like this one are failling (jarsigner also say so):

<testcase classname="org.netbeans.nbbuild.VerifyJNLP" name="/home/barboni/fork/netbeans/netbeans/nbbootstrap/netbeans/nbbuild/build/jnlp/org-eclipse-core-contenttype.jnlp/testSignatures" time="0.0">
<failure message="error examining signatures in /home/barboni/fork/netbeans/netbeans/nbbootstrap/netbeans/nbbuild/build/jnlp/org-eclipse-core-contenttype/org-eclipse-core-contenttype.jar: java.lang.SecurityException: invalid SHA1 signature file digest for org/eclipse/core/internal/content/XMLRootHandler$StopParsingException.class" type="junit.framework.AssertionFailedError">error examining signatures in /home/barboni/fork/netbeans/netbeans/nbbootstrap/netbeans/nbbuild/build/jnlp/org-eclipse-core-contenttype/org-eclipse-core-contenttype.jar: java.lang.SecurityException: invalid SHA1 signature file digest for org/eclipse/core/internal/content/XMLRootHandler$StopParsingException.class</failure>
</testcase>

<javaresource classpath="${cp.extra}" name="com/sun/jdi/Bootstrap.class"/>
<javaresource classpath="${cp.extra}" name="com/sun/jdi/StackFrame.class"/>
<javaresource classpath="${cp.extra}" name="com/sun/jdi/ObjectReference.class"/>
<javaresource classpath="${cp.extra}" name="com/sun/jdi/ThreadReference.class"/>
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no clue, why I need to use classpath="${cp.extra}" to make it work

@ebarboni ebarboni added the CI continuous integration changes label Apr 2, 2026
@mbien
Copy link
Copy Markdown
Member

mbien commented Apr 2, 2026

do we know if a minimal platform app would still start using webstart?

with the JDK removing SecurityManager (24) and AppContext (seems to happen now with 27), my guess is that the only LTS JDK where this still might work and we still support would be 21.

(I have nothing against fixing it if its not that much work and do a few releases with it fixed)

Copy link
Copy Markdown
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to the verify make sense to me. I read the code of the ant task as that the verification steps ensures, that all files found after build are actually used. This indeed would need someone with interest in the modules and JNLP interest to verify, but at least it gets the modules in a state of builability.

The signature and key algorithm changes makes sense to me.

The changes to the java/api.debugger.jpda and java.spi.debugger.jpda.ui modules make no sense right now as build-init is invoked on normal builds and so my question is: how can the problem be reproduced?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI continuous integration changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants