Improving code completion in presence of local classes.#9260
Open
lahodaj wants to merge 1 commit intoapache:masterfrom
Open
Improving code completion in presence of local classes.#9260lahodaj wants to merge 1 commit intoapache:masterfrom
lahodaj wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking at bug #9199 which regards to local classes (i.e. classes inside method bodies). The ultimate cause is that the code completion uses
TreeUtilities.parseType(String, TypeElement). Basing type attribution on a class will obviously not allow to resolve local classes - inside one class, there may be any number of local classes with the same name, among many other problems.The main part of this PR is an addition of
Scope-based version ofTU.parseType. I tried to use this new variant across the code completion code (except one place, where I can't convince myself the replacement makes sense).As a side-change, when one invokes the CC after e.g.:
the CC will contain the
Stringconstructors, but not the String class. But invoking it after e.g.:both the constructors and the class will be present, as the exclude is not done in this context. This PR adds the exclude at two places (mostly because I couldn't convince myself the tests should have different outcomes).
I left two TODO/NOTE in the patch for now, where we can discuss if the behavior is correct. I'll remove the TODOs when appropriate.
Tests added for hopefully all the places in the CC that were modified.
Additional side-changes are:
NBAttr, so that getting scope forCaseTree/JCCase"works"closes #9199
^Add meaningful description above
Click to collapse/expand PR instructions
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
PR approval and merge checklist:
If this PR targets the delivery branch: don't merge. (full wiki article)