Updating commons-lang3 and testng dependencies#9254
Updating commons-lang3 and testng dependencies#9254sid-srini wants to merge 3 commits intoapache:masterfrom
Conversation
Updated 3.17.0 -> 3.19.0 Repackaged jar with manifest attribute Import-Package value modified in order to avoid issues with older Netbinox even though OSGi v8 is used.
- Added testng-ant jar which has been separated now.
- Updated the lib spec version due to some breaking API changes of testng.
- Added dependency of slf4j-api-2.0.17 jar.
- Updated java/testng source to use the public APIs.
- Updated java/testng.ui source to use the public APIs.
- Updated nbbuild ant project template for testng to set verbose > 4, in
order for TestNG to initialize the VerboseReporter.
- This listener can no longer be used directly from the ant task
attribute due to the removal of the default constructor.
- Fixed broken unit tests in java/testng.ui, java/testng.ant
- Former fixed for JDK17+ runtime and java/j2seplatform for test.
- Latter fixed with missing data file and TestNG output changes.
Signed-off-by: Siddharth Srinivasan <siddharth.srinivasan@oracle.com>
|
I don't have much experience in the TestNG area so I looked at the classpath changes. TestNGs classpath change looked a bit scary at first but it might be optional deps. lang3 looks fine: TestNG: the whole guice branch (+snakeyyaml) seems to be optional: |
|
Thanks a lot @mbien for running all the CI tests, and, for going through the changes and dependencies. You are right that the majority of the listed dependencies are optional ones. The libraries included: slf4j and jcommander, were the non-optional ones that are required. Also, the testng jar already contains the jquery js components for the HTML reports it generates. Additionally, the testng-ant library is now included because it is now a separate library (also mentioned in the commit message of 8169a5c) and is used by NetBeans for running testng via ant. |
Updated the following third-party dependency modules:
^Add meaningful description above
Click to collapse/expand PR instructions
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
PR approval and merge checklist:
If this PR targets the delivery branch: don't merge. (full wiki article)