Skip to content

Conversation

@jbampton
Copy link
Member

No description provided.

@melloware melloware requested a review from volosied June 25, 2025 11:29
@bohmber
Copy link
Contributor

bohmber commented Jul 8, 2025

@jbampton did you test the result?

@tandraschko
Copy link
Member

and why is this required?
when the next user commits something different, its still missaligned

and TBH i dont like to accept such mass PRs

@jbampton
Copy link
Member Author

jbampton commented Sep 3, 2025

and why is this required? when the next user commits something different, its still missaligned

and TBH i dont like to accept such mass PRs

It is standard practice to end files with a newline. We can add a pre-commit hook that enforces this rule just like other top ASF projects.

So I have been waiting 2 months for #917 to be reviewed.

@tandraschko that is fine. I will close this PR and move on to another project. Thanks

@jbampton jbampton closed this Sep 3, 2025
@jbampton jbampton deleted the fix-end-of-files branch September 3, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants