Skip to content

misc: fix spelling #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
melloware merged 1 commit into from
May 26, 2025
Merged

misc: fix spelling #888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions impl/src/test/java/org/apache/myfaces/renderkit/html/HtmlMessageRendererTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ public void testHtmlPropertyPassTru() throws Exception

facesContext.addMessage(inputText.getClientId(facesContext),
new FacesMessage("Validation message here."));
facesContext.addMessage("test1", new FacesMessage(FacesMessage.Severity.WARN, "warnSumary", "detailWarnSummary"));
facesContext.addMessage("test1", new FacesMessage(FacesMessage.Severity.WARN, "warnSummary", "detailWarnSummary"));
message.setErrorClass(ERROR_CLASS);
message.setWarnClass(WARN_CLASS);
message.setInfoClass(INFO_CLASS);
Expand All @@ -149,7 +149,7 @@ public void testHtmlPropertyPassTru() throws Exception
@Test
public void testRenderSpanOnlyWhenNecessary() throws Exception
{
facesContext.addMessage(inputText.getClientId(), new FacesMessage(FacesMessage.Severity.WARN, "warnSumary", "detailWarnSummary"));
facesContext.addMessage(inputText.getClientId(), new FacesMessage(FacesMessage.Severity.WARN, "warnSummary", "detailWarnSummary"));
message.setFor("myInputId");
message.encodeEnd(facesContext);
facesContext.renderResponse();
Expand All @@ -164,7 +164,7 @@ public void testHtmlPropertyPassTruNotRendered() throws Exception

facesContext.addMessage(inputText.getClientId(facesContext),
new FacesMessage("Validation message here."));
facesContext.addMessage("test1", new FacesMessage(FacesMessage.Severity.WARN, "warnSumary", "detailWarnSummary"));
facesContext.addMessage("test1", new FacesMessage(FacesMessage.Severity.WARN, "warnSummary", "detailWarnSummary"));
message.setErrorClass(ERROR_CLASS);
message.setWarnClass(WARN_CLASS);
message.setInfoClass(INFO_CLASS);
Expand Down
26 changes: 13 additions & 13 deletions impl/src/test/java/org/apache/myfaces/renderkit/html/HtmlMessagesRendererTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,8 @@ public void testHtmlPropertyPassTru() throws Exception
new HtmlRenderedAttr("warnStyle", "warnStyle", "style=\"warnStyle\"",2)
};

facesContext.addMessage("test1", new FacesMessage(FacesMessage.Severity.WARN, "warnSumary", "detailWarnSummary"));
facesContext.addMessage("test2", new FacesMessage(FacesMessage.Severity.WARN, "warnSumary2", "detailWarnSummary2"));
facesContext.addMessage("test1", new FacesMessage(FacesMessage.Severity.WARN, "warnSummary", "detailWarnSummary"));
facesContext.addMessage("test2", new FacesMessage(FacesMessage.Severity.WARN, "warnSummary2", "detailWarnSummary2"));

messages.setErrorClass(ERROR_CLASS);
messages.setWarnClass(WARN_CLASS);
Expand All @@ -139,35 +139,35 @@ public void testHtmlPropertyPassTru() throws Exception
@Test
public void testRenderSpanOnlyWhenNecessary1() throws Exception
{
facesContext.addMessage("test1", new FacesMessage(FacesMessage.Severity.WARN, "warnSumary", "detailWarnSummary"));
facesContext.addMessage("test1", new FacesMessage(FacesMessage.Severity.WARN, "warnSummary", "detailWarnSummary"));
messages.encodeEnd(facesContext);
facesContext.renderResponse();
String output = writer.getWriter().toString();
Assertions.assertTrue(output.contains("warnSumary"));
Assertions.assertTrue(output.contains("warnSummary"));
Assertions.assertTrue(!output.contains("span"));
}

@Test
public void testRenderSpanOnlyWhenNecessary2() throws Exception
{
facesContext.addMessage("test1", new FacesMessage(FacesMessage.Severity.WARN, "warnSumary", "detailWarnSummary"));
facesContext.addMessage("test1", new FacesMessage(FacesMessage.Severity.WARN, "warnSummary", "detailWarnSummary"));
messages.setLayout("table");
messages.encodeEnd(facesContext);
facesContext.renderResponse();
String output = writer.getWriter().toString();
Assertions.assertTrue(output.contains("warnSumary"));
Assertions.assertTrue(output.contains("warnSummary"));
Assertions.assertTrue(!output.contains("span"));
}

@Test
public void testRenderSpanOnlyWhenNecessary3() throws Exception
{
facesContext.addMessage("test1", new FacesMessage(FacesMessage.Severity.WARN, "warnSumary", "detailWarnSummary"));
facesContext.addMessage("test1", new FacesMessage(FacesMessage.Severity.WARN, "warnSummary", "detailWarnSummary"));
messages.setId("msgPanel");
messages.encodeEnd(facesContext);
facesContext.renderResponse();
String output = writer.getWriter().toString();
Assertions.assertTrue(output.contains("warnSumary"));
Assertions.assertTrue(output.contains("warnSummary"));
Assertions.assertTrue(!output.contains("span"));
}

Expand All @@ -178,13 +178,13 @@ public void testRenderSpanOnlyWhenNecessary3() throws Exception
@Test
public void testRenderSpanOnlyWhenNecessary4() throws Exception
{
facesContext.addMessage("test1", new FacesMessage(FacesMessage.Severity.FATAL, "fatalSumary", "detailFatalSummary"));
facesContext.addMessage("test1", new FacesMessage(FacesMessage.Severity.FATAL, "fatalSummary", "detailFatalSummary"));
messages.setId("msgPanel");
messages.setFatalClass("fatalClass");
messages.encodeEnd(facesContext);
facesContext.renderResponse();
String output = writer.getWriter().toString();
Assertions.assertTrue(output.contains("fatalSumary"));
Assertions.assertTrue(output.contains("fatalSummary"));
Assertions.assertTrue(output.contains("li class=\"fatalClass\""));
Assertions.assertTrue(!output.contains("span"));
}
Expand All @@ -196,14 +196,14 @@ public void testRenderSpanOnlyWhenNecessary4() throws Exception
@Test
public void testRenderSpanOnlyWhenNecessary5() throws Exception
{
facesContext.addMessage("test1", new FacesMessage(FacesMessage.Severity.FATAL, "fatalSumary", "detailFatalSummary"));
facesContext.addMessage("test1", new FacesMessage(FacesMessage.Severity.FATAL, "fatalSummary", "detailFatalSummary"));
messages.setId("msgPanel");
messages.setLayout("table");
messages.setFatalClass("fatalClass");
messages.encodeEnd(facesContext);
facesContext.renderResponse();
String output = writer.getWriter().toString();
Assertions.assertTrue(output.contains("fatalSumary"));
Assertions.assertTrue(output.contains("fatalSummary"));
Assertions.assertTrue(output.contains("td class=\"fatalClass\""));
Assertions.assertTrue(!output.contains("span"));
}
Expand All @@ -213,7 +213,7 @@ public void testHtmlPropertyPassTruNotRendered() throws Exception
{
HtmlRenderedAttr[] attrs = HtmlCheckAttributesUtil.generateAttrsNotRenderedForReadOnly();

facesContext.addMessage("test1", new FacesMessage(FacesMessage.Severity.WARN, "warnSumary", "detailWarnSummary"));
facesContext.addMessage("test1", new FacesMessage(FacesMessage.Severity.WARN, "warnSummary", "detailWarnSummary"));

messages.setErrorClass(ERROR_CLASS);
messages.setWarnClass(WARN_CLASS);
Expand Down