Skip to content

[#11767] Fix consumer POM builder failing to resolve BOM imports from…#11768

Open
DavidTavoularis wants to merge 1 commit intoapache:masterfrom
DavidTavoularis:fix/consumer-pom-repositories
Open

[#11767] Fix consumer POM builder failing to resolve BOM imports from…#11768
DavidTavoularis wants to merge 1 commit intoapache:masterfrom
DavidTavoularis:fix/consumer-pom-repositories

Conversation

@DavidTavoularis
Copy link

… settings.xml profile repositories

DefaultConsumerPomBuilder.buildModel() now passes repositories, profiles, and active profile IDs to the ModelBuilderRequest so that BOM imports from non-central repositories (e.g. defined in settings.xml profiles) can be resolved during consumer POM transformation.

DefaultModelBuilder.derive() now respects the request's repositories instead of always reusing the parent session's, and caches the RepositoryFactory lookup.

Includes unit tests for both fixes and an integration test (gh-11767).

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

…s from settings.xml profile repositories

DefaultConsumerPomBuilder.buildModel() now passes repositories, profiles, and
active profile IDs to the ModelBuilderRequest so that BOM imports from
non-central repositories (e.g. defined in settings.xml profiles) can be resolved
during consumer POM transformation.

DefaultModelBuilder.derive() now respects the request's repositories instead of
always reusing the parent session's, and caches the RepositoryFactory lookup.

Includes unit tests for both fixes and an integration test (apachegh-11767).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant