Add additional locations for auto-discovery to scan#130
Add additional locations for auto-discovery to scan#130Okeanos wants to merge 1 commit intoapache:masterfrom
Conversation
|
@gnodet can you take a look? |
| } else { | ||
| installedDirs.add(Paths.get("/usr/jdk")); | ||
| installedDirs.add(Paths.get("/usr/java")); | ||
| installedDirs.add(Paths.get("/usr/local/java")); |
There was a problem hiding this comment.
Which tool uses this directory ?
There was a problem hiding this comment.
This is based on the proposed alignment with the Gradle toolchain detection I mentioned in #129 – the original proposal for Gradle is documented in gradle/gradle#23620 and boils down to "people put it there during manual installations as common default".
I have no strong opinion on this and I am willing to exclude this particular search folder as it is a "customary" but ultimately a user-defined location.
|
@gnodet is there anything from my side still missing for this to proceed? If so, please let me know and I'll have a look. Other than that I'd be interested to know when this might be merged and potentially a new release of the Toolchains Plugin be released. |
Add additional locations for auto-discovery to scan
Resolves #129
Since 3f9736c running tests locally (on macOS) fails the build; I have not yet had the chance to debug this fully and understand whether it's a setup problem on my machine.
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.