GH-1737: Revert partially parallel upload change #1765
+14
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert partially (connector only) commit: 09c3fa9 Fixes apache#1737
kwin
approved these changes
Jan 27, 2026
Member
kwin
left a comment
kwin
left a comment
There was a problem hiding this comment.
Thanks, looks good. But deserves an clarification in the documentation of https://maven.apache.org/resolver/configuration.html for aether.connector.basic.parallelPut.
kwin
reviewed
Jan 27, 2026
| | `"aether.conflictResolver.versionSelector.selectionStrategy"` | `String` | The name of the version selection strategy to use in conflict resolution: "nearest" (default) or "highest". | `"nearest"` | 2.0.11 | No | Session Configuration | | ||
| | `"aether.connector.basic.downstreamThreads"` | `Integer` | Number of threads in basic connector for downloading. | `5` | 2.0.0 | Yes | Session Configuration | | ||
| | `"aether.connector.basic.parallelPut"` | `Boolean` | Enables or disables parallel PUT processing (parallel deploys) on basic connector globally or per remote repository. When disabled, connector behaves exactly as in Maven 3.8.x did: GETs are parallel while PUTs are sequential. | `true` | 1.9.5 | Yes | Session Configuration | | ||
| | `"aether.connector.basic.parallelPut"` | `Boolean` | Enables or disables parallel PUT processing (parallel deploys) on basic connector globally or per remote repository. When disabled, connector behaves exactly as in Maven 3.8.x did: GETs are parallel while PUTs are sequential. When enabled, connector will issue first PUT sequentially and the rest of PUTs in parallel. | `true` | 1.9.5 | Yes | Session Configuration | |
Member
There was a problem hiding this comment.
Suggested change
| | `"aether.connector.basic.parallelPut"` | `Boolean` | Enables or disables parallel PUT processing (parallel deploys) on basic connector globally or per remote repository. When disabled, connector behaves exactly as in Maven 3.8.x did: GETs are parallel while PUTs are sequential. When enabled, connector will issue first PUT sequentially and the rest of PUTs in parallel. | `true` | 1.9.5 | Yes | Session Configuration | | |
| | `"aether.connector.basic.parallelPut"` | `Boolean` | Enables or disables parallel PUT processing (parallel deploys) on basic connector globally or per remote repository. When disabled, connector behaves exactly as in Maven 3.8.x did: GETs are parallel while PUTs are sequential. When enabled, connector will issue first PUT individually and only once completed the rest of PUTs in parallel. This is to make sure that receiving repository managers will be able to correctly prepare things like staging repos with the first request and associate the subsequent parallel ones to the first one. | `true` | 1.9.5 | Yes | Session Configuration | |
Member
Author
There was a problem hiding this comment.
@kwin this is generated markdown from Javadoc (and we did not know better than to check in generated file). The source is in Javadoc of this file:
https://github.com/apache/maven-resolver/pull/1765/changes#diff-53426dfed2b513628c93a211ce19725fb3fc8512f02e2ac2f2a093d871481ef2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert partially (connector only) commit:
09c3fa9
Fixes #1737