Skip to content

Minimize dependencies on JUnit5 in MavenProjectStub #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
slawekjaranowski wants to merge 1 commit into
base: maven-plugin-testing-3.x
Choose a base branch
from
+7 −1
Open

Minimize dependencies on JUnit5 in MavenProjectStub #264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...testing-harness/src/main/java/org/apache/maven/plugin/testing/stubs/MavenProjectStub.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
import org.apache.maven.model.Scm;
import org.apache.maven.model.io.xpp3.MavenXpp3Reader;
import org.apache.maven.project.MavenProject;
import org.codehaus.plexus.PlexusTestCase;
import org.codehaus.plexus.testing.PlexusExtension;
import org.codehaus.plexus.util.xml.XmlStreamReader;
import org.codehaus.plexus.util.xml.Xpp3Dom;
Expand Down Expand Up @@ -288,7 +289,12 @@ public void setFile(File file) {
/** {@inheritDoc} */
@Override
public File getBasedir() {
return new File(PlexusExtension.getBasedir());
try {
return new File(PlexusExtension.getBasedir());
} catch (Throwable e) {
// PlexusExtension use JUnit5 API, so in case of JUnit4 test, fallback to old PlexusTestCase
return new File(PlexusTestCase.getBasedir());
}
}

/**
Expand Down