Skip to content

Conversation

@slawekjaranowski
Copy link
Member

@slawekjaranowski slawekjaranowski commented Jan 10, 2026

  • Migration finished
  • bump plugin-testing to 3.5.0
  • cleanups after parent

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Copy link
Contributor

@sparsick sparsick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please check if the following dependencies are still necessary:

    <dependency>
      <!-- support for JUnit 4 -->
      <groupId>org.junit.vintage</groupId>
      <artifactId>junit-vintage-engine</artifactId>
      <scope>test</scope>
    </dependency>
    <dependency>
      <groupId>junit</groupId>
      <artifactId>junit</artifactId>
      <version>4.13.2</version>
      <scope>test</scope>
    </dependency>

Should we rename the test classes, so that they have a Test suffix?

@slawekjaranowski slawekjaranowski marked this pull request as ready for review January 17, 2026 11:55
@slawekjaranowski
Copy link
Member Author

slawekjaranowski commented Jan 17, 2026

Should we rename the test classes, so that they have a Test suffix?

There are many tests to rename .... we can do it in separate PR

@slawekjaranowski slawekjaranowski merged commit 4e021c0 into apache:master Jan 18, 2026
17 checks passed
@slawekjaranowski slawekjaranowski deleted the junit5-0110 branch January 18, 2026 08:00
@github-actions github-actions bot added this to the 3.10.0 milestone Jan 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants