Optimize artifact lookup in DefaultProjectDependencyAnalyzer#270
Open
sanjana2505006 wants to merge 1 commit intoapache:masterfrom
Open
Optimize artifact lookup in DefaultProjectDependencyAnalyzer#270sanjana2505006 wants to merge 1 commit intoapache:masterfrom
sanjana2505006 wants to merge 1 commit intoapache:masterfrom
Conversation
Author
|
Hello @slawekjaranowski, I’ve opened a PR with a small improvement I noticed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing the core analysis logic, I noticed a performance bottleneck in$O(N)$ for every class usage), which could be a bottleneck in large projects with many dependencies. These changes switch to a
DefaultProjectDependencyAnalyzer. \n\nPreviously, it used a linear search to find which artifact a class belongs to (Map-based lookup ($O(1)$) and modernize the code usingcomputeIfAbsentand more robust scope checks.\n\nThis significantly improves the efficiency of the analysis process for projects with large dependency trees.