Implement missing tests and cleanup TODOs in DependencyVisitorTest#269
Open
sanjana2505006 wants to merge 1 commit intoapache:masterfrom
Open
Implement missing tests and cleanup TODOs in DependencyVisitorTest#269sanjana2505006 wants to merge 1 commit intoapache:masterfrom
sanjana2505006 wants to merge 1 commit intoapache:masterfrom
Conversation
Author
|
Hello @slawekjaranowski, I’ve opened a PR with a small improvement I noticed. |
sanjana2505006
force-pushed
the
chore/fix-dependency-visitor-todos
branch
from
dbbe470 to
69bcf03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking through the codebase, I noticed a couple of TODOs in
DependencyVisitorTestthat were still pending.I've implemented a new test case,
testVisitFieldWithValue, which ensures that dependency collection correctly handles situations where a Type is passed as a default field value. I also updated thetestVisitInnerClasstest to use more realistic inner class naming conventions (like a/b/c$x), which allowed me to safely remove the remaining TODO there as well.