Skip to content

Conversation

@Rutuja123-dos
Copy link
Contributor

@Rutuja123-dos Rutuja123-dos commented Jan 16, 2026

Purpose of PR

This PR adds a regression test for the async amplitude encoding chunk bounds issue (#743).
The Problem: When performing amplitude encoding in chunks, the kernel must respect the specific chunk_len for the offset provided, rather than the full state_len. Out-of-bounds writes can occur if the bounds are not correctly constrained.

Related Issues or PRs

Closes #743

Changes Made

  • Bug fix
  • New feature
  • Refactoring
  • Documentation
  • Test
  • CI/CD pipeline
  • Other

Breaking Changes

  • Yes
  • No

Checklist

  • Added or updated unit tests for all changes
  • Added or updated documentation for all changes
  • Successfully built and ran all unit tests or manual tests locally
  • PR title follows "MAHOUT-XXX: Brief Description" format (if related to an issue)
  • Code follows ASF guidelines

Copy link
Member

@ryankert01 ryankert01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't test external package

@Rutuja123-dos
Copy link
Contributor Author

Thanks for the feedback @ryankert01. You’re right, I see now that this test is just checking NumPy and not the actual project logic.
I’m going to look back at the source code to find the exact function that’s causing the out-of-bounds issue. I'll rewrite the test to call that function instead and update my PR. Thanks for pointing that out

@400Ping
Copy link
Contributor

400Ping commented Jan 17, 2026

Please actually take a good look of the codebase before you submit a PR for it, you also added some unnecessary comments and your reply seems very GPT like answer. I do encourage using AI agents stuff to write code, but you need to understand the context and what it is producing. Don't just upload whatever it says like a no-brainer.

@Rutuja123-dos
Copy link
Contributor Author

Closing this for now. I've realized my local build environment is a bit too limited for these GPU/Rust changes and it's becoming a major blocker. I’m going to step back from this one and look for some other areas to contribute instead. Thanks for the help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants