[Feature][QDP] Add AMD GPU support via Triton backend#1158
Draft
400Ping wants to merge 17 commits intoapache:mainfrom
Draft
[Feature][QDP] Add AMD GPU support via Triton backend#1158400Ping wants to merge 17 commits intoapache:mainfrom
400Ping wants to merge 17 commits intoapache:mainfrom
Conversation
Signed-off-by: 400Ping <jiekaichang@apache.org>
Signed-off-by: 400Ping <jiekaichang@apache.org>
Member
Author
|
Just noticed that colab doesn't have AMD GPU options, so we may need to ask AMD for collaboration. Or I will looked into modal if I can rent one. |
Member
Author
|
On second thought, let me see if I can rent one first. |
Member
|
Let's turn this one to draft to prevent early review. |
Tcc0403
reviewed
Apr 16, 2026
Signed-off-by: 400Ping <jiekaichang@apache.org>
Signed-off-by: 400Ping <jiekaichang@apache.org>
Member
Author
Tested on AMD Instinct MI300X |
Signed-off-by: 400Ping <jiekaichang@apache.org>
Signed-off-by: 400Ping <jiekaichang@apache.org>
Member
Author
|
cc @viiccwen to take a look |
guan404ming
reviewed
Apr 18, 2026
Member
guan404ming
left a comment
There was a problem hiding this comment.
Thanks for the patch, just left some nit comments.
Signed-off-by: 400Ping <jiekaichang@apache.org>
guan404ming
approved these changes
Apr 18, 2026
Member
guan404ming
left a comment
There was a problem hiding this comment.
Great, I think we could work on this and refine this. Thanks!
ryankert01
reviewed
Apr 19, 2026
rich7420
reviewed
Apr 19, 2026
Contributor
rich7420
left a comment
There was a problem hiding this comment.
thanks for the patch! left some comments
Member
Author
|
I am fixing some of the implementations, putting this to draft. |
Signed-off-by: 400Ping <jiekaichang@apache.org>
Signed-off-by: 400Ping <jiekaichang@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #1155
Changes
Why
QDP currently assumes the CUDA/native
_qdppath, which makes the Python API effectively NVIDIA-only.This change adds an AMD/ROCm execution path so QDP can run on AMD GPUs while keeping the existing CUDA route intact.
The goal of this PR is to:
QdpEngineentry point for backend selectionUser-Facing Behavior
CUDA:
AMD/ROCm:
Testing
Checklist