Move parent field from DWPT to IndexingChain#15960
Open
Tim-Brooks wants to merge 4 commits intoapache:mainfrom
Open
Move parent field from DWPT to IndexingChain#15960Tim-Brooks wants to merge 4 commits intoapache:mainfrom
Tim-Brooks wants to merge 4 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parent field (used for block indexing) was previously managed by
DWPT: it created a ReservedField wrapper, injected the field into the
last document's iterator via addParentField(), and relied on a
delegating ReservedField class to guard the field name from external
use.
Move ownership of the parent field into IndexingChain, where field
schemas and processing already live. The parent field and its PerField
are created once in the IndexingChain constructor, and processDocument
handles it directly in both passes when lastDocInBlock is true.
Reserved field detection uses a simple identity check (pf == parentPf)
instead of the ReservedField wrapper class.
This removes ~90 lines of boilerplate (ReservedField, addParentField
iterator, reserved boolean on PerField) and avoids per-document iterator
allocation and redundant schema re-validation for the parent field.