Ensure that index is actually there in LegacyBaseDocValuesFormatTestCase#15767
Open
romseygeek wants to merge 1 commit intoapache:mainfrom
Open
Ensure that index is actually there in LegacyBaseDocValuesFormatTestCase#15767romseygeek wants to merge 1 commit intoapache:mainfrom
romseygeek wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
Author
|
This could conceivably go into a 10.4.1 if we release one? I'll wait until 10.4.0 is actually finished before adding a Changes entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In rare cases, testSortedNumericsSingleValuedMissingVsStoredFields in
LegacyBaseDocValuesFormatTestCase can fail because the various random
parameters determining flush and commit rates line up badly, and we don't
actually write any data to the test index before trying to open it. This adds
an explicit commit() call so that we avoid spurious failures, in line with other
similar tests in this suite.