Store pre-aggregated sum and value count in DocValuesSkipper#15737
Open
jainankitk wants to merge 8 commits intoapache:mainfrom
Open
Store pre-aggregated sum and value count in DocValuesSkipper#15737jainankitk wants to merge 8 commits intoapache:mainfrom
jainankitk wants to merge 8 commits intoapache:mainfrom
Conversation
Signed-off-by: Ankit Jain <jainankitk@apache.org>
Signed-off-by: Ankit Jain <jainankitk@apache.org>
Signed-off-by: Ankit Jain <jainankitk@apache.org>
Signed-off-by: Ankit Jain <jainankitk@apache.org>
Signed-off-by: Ankit Jain <jainankitk@apache.org>
This reverts commit 36aec7b.
Contributor
|
@jainankitk will adding these new things in the docvaluesSkipper add an extra burden on the indexing side? |
Contributor
I am not sure if you went through the original issue, the entire point is to store pre-aggregated data in the doc values skipper so we can take advantage of it at search time. So that it's intentional. |
Contributor
Thank you. Will look into the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR extends the DocValues skip index to store pre-aggregated sum and valueCount alongside the existing min/max per interval. This enables collectors and faceting operations to leverage pre-computed aggregation data at search time, avoiding the need to iterate through individual doc values.
Issue
Resolves #13870