Add adversary model and revision section to common threat model#30
Merged
Conversation
Extend the common threat model with two new sections: * "Adversary capabilities" defines the in-scope adversary and the capabilities it is assumed to have, and enumerates the out-of-scope adversaries whose reports will not be accepted. * "Revising this threat model" lists the conditions under which the document must be revisited. Self-referential and deeply nested object structures are explicitly placed out of scope. To keep disabled log statements cheap we call `toString()` on the passed parameters ourselves, so the safety of that call ultimately rests with the caller. This follows the CVE-2017-18640 precedent: SnakeYAML did not hang while _reading_ a "billion laughs" document, but it built a deeply nested map from it, and SnakeYAML, not the code that later operated on that map, was held responsible. Note that SnakeYAML still allows the creation of recursive maps by default. Open questions left for discussion: * The revision section does not yet define the process for modifying the threat model. This should likely require a public discussion followed by a public PMC vote. * Retroactivity: changes should apply only to versions published *after* the modification, not retroactively. If we adopt that, we should keep all previously published versions of this document available on the website. Assisted-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
rm5248
reviewed
May 16, 2026
FreeAndNil
reviewed
May 16, 2026
Co-authored-by: Jan Friedrich <43271715+FreeAndNil@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the common threat model with two new sections:
Self-referential and deeply nested object structures are explicitly placed out of scope. To keep disabled log statements cheap we call
toString()on the passed parameters ourselves, so the safety of that call ultimately rests with the caller. This follows the CVE-2017-18640 precedent: SnakeYAML did not hang while reading a "billion laughs" document, but it built a deeply nested map from it, and SnakeYAML, not the code that later operated on that map, was held responsible. Note that SnakeYAML still allows the creation of recursive maps by default.Open questions left for discussion:
Assisted-By: Claude Opus 4.7 (1M context) noreply@anthropic.com