[LOG4J2-2006] RollingFile createOnDemand validation#4072
Open
ramanathan1504 wants to merge 1 commit intoapache:2.xfrom
Open
[LOG4J2-2006] RollingFile createOnDemand validation#4072ramanathan1504 wants to merge 1 commit intoapache:2.xfrom
ramanathan1504 wants to merge 1 commit intoapache:2.xfrom
Conversation
…r and add tests for createOnDemand behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Notes: RollingFile
createOnDemandvalidationScope
spring-boot-testonlycore-java-testandlog4j2-web-testleft unchangedWhat was run
2.26.0-SNAPSHOTartifacts resolved from~/.m2SpringBootTestApp#printLogPathStateused as source of truthResults (
2.26.0-SNAPSHOT)createOnDemand="true"(defaultlog4j2.xml)main-entry:dir=false app.log=false app-json.log=falseafter LogManager.getLogger:dir=false app.log=false app-json.log=falseafter first log event:dir=true app.log=true app-json.log=trueConclusion: directory and files are created on first log event (expected on-demand behavior).
createOnDemand="false"(log4j2-createOnDemand-false.xml)main-entry:dir=false app.log=false app-json.log=falseafter LogManager.getLogger:dir=true app.log=true app-json.log=trueafter first log event:dir=true app.log=true app-json.log=trueConclusion: eager creation occurs before first log event (expected non-demand behavior).