Only call super() during MockHttp if required#2033
Merged
Kami merged 6 commits intoapache:trunkfrom Mar 2, 2025
Merged
Conversation
With pytest 8.2 and above, any class that contains classes is collected, which means they are instantiated, which MockHttp's superclasses do not accept, since they require keyword arguments. To work around this, only call the superclass's __init__ method if we are passed kwargs.
Member
|
Thanks for the contribution. I've intentionally help back at upgrading pytest since we rely on test collection logic which has changed in new version of pytest so various tests are not being collected correctly. I will test and verify this change locally with latest version of pytest. |
…libcloud into s-t-e-v-e-n-k-only-call-super-if-needed
Member
|
@s-t-e-v-e-n-k I've tested it locally and it indeed appears to be working fine. Before: After (with pytest > 8.2): I will merge it into trunk shortly. Thanks. |
Kami
approved these changes
Mar 2, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #2033 +/- ##
==========================================
- Coverage 83.40% 83.40% -0.00%
==========================================
Files 353 353
Lines 81684 81685 +1
Branches 8631 8632 +1
==========================================
Hits 68124 68124
Misses 10738 10738
- Partials 2822 2823 +1
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only instantiate superclasses of MockHttp if we are provided keyword arguments
Description
With pytest 8.2 and above, any class that contains tests is collected, which means they are instantiated, which MockHttp's superclasses do not accept, since they require keyword arguments. To work around this, only call the superclass's init method if we are passed kwargs.
Status
Done, ready for review
Checklist (tick everything that applies)