-
Notifications
You must be signed in to change notification settings - Fork 52
docs: update SELECT command for redis-databases support #345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hanxi
wants to merge
1
commit into
apache:main
Choose a base branch
from
hanxi:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-hulk
reviewed
Dec 19, 2025
|
|
||
| In Kvrocks the `SELECT` command is just a placeholder and does not switch between dbs. | ||
| Use [the namespace feature](https://kvrocks.apache.org/docs/namespace) instead if multiple dbs are needed. | ||
| The `SELECT` command is a placeholder by default (`redis-databases = 0`). When `redis-databases` > 0, it switches between databases (0 to redis-databases-1). Database 0 uses the default namespace, databases 1-N use `db1`, `db2`, etc. Enabling this disables custom namespaces. Use [the namespace feature](https://kvrocks.apache.org/docs/namespace) for multiple isolated databases without `redis-databases`. |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| The `SELECT` command is a placeholder by default (`redis-databases = 0`). When `redis-databases` > 0, it switches between databases (0 to redis-databases-1). Database 0 uses the default namespace, databases 1-N use `db1`, `db2`, etc. Enabling this disables custom namespaces. Use [the namespace feature](https://kvrocks.apache.org/docs/namespace) for multiple isolated databases without `redis-databases`. | |
| In Kvrocks the `SELECT` command is just a placeholder and does not switch between dbs if the `redis-database` is not enabled(`redis-databases = 0` by default). | |
| A [the namespace feature](https://kvrocks.apache.org/docs/namespace) instead if multiple dbs are needed. | |
| Before [NEXT RELEASE VERSION], Kvrocks only allowed using [the namespace feature](https://kvrocks.apache.org/docs/namespace) to isolate your data. That said, the `SELECT` command is just a placeholder and does not switch between databases. And now, the Redis database mechanism is supported, and you can enable it by setting the `redis-database` to the database number you expect in the configuration file. | |
| To be noticed, we don't allow using the namespace feature and the Redis database at the same time. |
| | LASTSAVE | ✓ | v2.6.0 | Returns the timestamp of the last successful save to disk. Additionally, `LASTSAVE ISO8601` returns the time in ISO8601 format. | | ||
| | PING | ✓ | v1.0.0 | Checks if the server is alive, responding with "PONG." | | ||
| | SELECT | ✓ | v1.0.0 | simply returns OK. | | ||
| | SELECT | ✓ | unstable | Switches between databases when `redis-databases` > 0 (default 0: returns OK without switching). | |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| | SELECT | ✓ | unstable | Switches between databases when `redis-databases` > 0 (default 0: returns OK without switching). | | |
| | SELECT | ✓ | v1.0.0 | Switches between databases when `redis-databases` > 0 (default 0: returns OK without switching) since [NEXT RELEASE VERSION]. | |
Member
|
@hanxi We can put this change on hold until the next future version is released. cc @PragmaTwice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.