Open
Conversation
jbonofre
approved these changes
Mar 14, 2026
jbonofre
approved these changes
Mar 14, 2026
holgerfriedrich
force-pushed
the
pr-maven-4
branch
from
4ee6e32 to
b37cb35
Compare
jbonofre
approved these changes
Mar 14, 2026
holgerfriedrich
force-pushed
the
pr-maven-4
branch
from
b37cb35 to
58ca72b
Compare
holgerfriedrich
force-pushed
the
pr-maven-4
branch
from
58ca72b to
21787dc
Compare
Test Results233 files ±0 233 suites ±0 22m 11s ⏱️ +17s Results for commit 21787dc. ± Comparison against base commit f6e980e. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This basically allows building Karaf with maven4-rc5.
First addition is the directory
.mvnto mark the top directory of the workspace. Not strictly necessary, but it suppresses the warning about missing top level directory marker during build with Maven 4.The approach to add .mvn dir is the option that does not impact our standard builds with Maven 3.
The second addition is a missing version specification in a pom file. Without it, Maven4 just picks the wrong version of the maven-resources-plugin, which is built against an old API and is causing the build to fail.
We still get warnings about BOM import. This is a bigger change an currently does not break the build. It is not in scope of this PR.