Open
Conversation
| for (Map.Entry<TopicIdPartition, Acknowledgements> entry : acknowledgementsMap.entrySet()) { | ||
| recordsRenewed += batches.get(entry.getKey()).renew(entry.getValue()); | ||
| ShareInFlightBatch<K, V> batch = batches.get(entry.getKey()); | ||
| if (batch != null) { |
Contributor
There was a problem hiding this comment.
Nice catch on the NPE. Only nit: can we add a brief note on renew that missing batches are intentionally skipped?
chia7712
approved these changes
Mar 21, 2026
| int recordsRenewed = 0; | ||
| for (Map.Entry<TopicIdPartition, Acknowledgements> entry : acknowledgementsMap.entrySet()) { | ||
| recordsRenewed += batches.get(entry.getKey()).renew(entry.getValue()); | ||
| ShareInFlightBatch<K, V> batch = batches.get(entry.getKey()); |
Member
There was a problem hiding this comment.
Good defensive check, but just out of curiosity, what causes this to end up being null?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a potential NPE in
ShareFetch. I have hit it once duringtesting, but only once. Fix in progress on trunk and will include in
4.3.0. This is worth putting into 4.2.1.