KAFKA-20343: Refactor LogCleanerLagIntegrationTest to use a builder for LogCleaner setup#21843
Open
nileshkumar3 wants to merge 3 commits intoapache:trunkfrom
Open
KAFKA-20343: Refactor LogCleanerLagIntegrationTest to use a builder for LogCleaner setup#21843nileshkumar3 wants to merge 3 commits intoapache:trunkfrom
nileshkumar3 wants to merge 3 commits intoapache:trunkfrom
Conversation
…st to use the builder pattern
github-actions
Bot
added
triage
Contributor
Author
Thanks for the nit — I rechecked every migrated callsite against the old makeCleaner overloads; behavior for backoff and segment size is unchanged. I set the builder’s default backoff to CleanerConfig.LOG_CLEANER_BACKOFF_MS and added explicit .segmentSize(DEFAULT_SEGMENT_SIZE) on the two tests that used makeCleaner(partitions, maxMessageSize, backoffMs) so 2048 stays obvious at the call site. |
Resolve conflict in LogCleanerIntegrationTest: keep LogCleanerTestFixtureBuilder, migrate remaining makeCleaner call sites from merged trunk content, add propertyOverrides/cleanerIoBufferSize fluent methods and logConfigProperties(int). Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the makeCleaner overload chain in LogCleanerLagIntegrationTest with a small fluent builder so call sites use named configuration instead of positional overloads.