MINOR: Remove boilerplate code from header serializer test#21837
Open
iit2009060 wants to merge 4 commits intoapache:trunkfrom
Open
MINOR: Remove boilerplate code from header serializer test#21837iit2009060 wants to merge 4 commits intoapache:trunkfrom
iit2009060 wants to merge 4 commits intoapache:trunkfrom
Conversation
iit2009060
force-pushed
the
minor-remove-bolierplate-header-serializer
branch
from
2d42c9a to
0dc445f
Compare
mjsax
reviewed
Mar 20, 2026
Member
mjsax
left a comment
mjsax
left a comment
There was a problem hiding this comment.
There is three more test classes with the same pattern, which we should update, too.
| } | ||
| } | ||
|
|
||
| public static byte[] serialize(final Headers headers) { |
Member
There was a problem hiding this comment.
Suggested change
| public static byte[] serialize(final Headers headers) { | |
| // for testing | |
| public static byte[] serialize(final Headers headers) { |
Contributor
Author
|
mjsax
changed the title
mjsax
reviewed
Mar 20, 2026
streams/src/main/java/org/apache/kafka/streams/state/internals/HeadersSerializer.java
Outdated
Show resolved
Hide resolved
mjsax
approved these changes
Mar 20, 2026
mjsax
reviewed
Mar 20, 2026
streams/src/main/java/org/apache/kafka/streams/state/internals/HeadersSerializer.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces HeadersSerializer.serialize(Headers) as a one-line
alternative to the two-phase serialization API (prepareSerialization +
serialize), reducing boilerplate in test code.
Reviewers: Matthias J. Sax matthias@confluent.io, Nilesh Kumar
nileshkumar3@gmail.com