KAFKA-15853: [1/N] Move static methods, SocketServer and Log configs to AbstractKafkaConfig by clolov · Pull Request #21548 · apache/kafka

clolov · 2026-02-23T15:33:19Z

This is a gradual migration of KafkaConfig to Java for easier reviews.

Moved the static methods to AbstractKafkaConfig and the methods used to
access SocketServer and Log configs.

Reviewers: Chia-Ping Tsai chia7712@gmail.com

UladzislauBlok · 2026-02-25T10:46:51Z

@clolov Hello. I will re-assign ticket to you. Thanks for picking this up. That's the big one :)

github-actions · 2026-03-03T03:51:35Z

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

…KafkaConfig

chia7712 · 2026-03-19T08:49:24Z

we need to fix the failed testSpecificProperties by making following change.

- assertEquals(Map("127.0.0.1" -> 2, "127.0.0.2" -> 3), config.maxConnectionsPerIpOverrides)
+ assertEquals(util.Map.of("127.0.0.1", 2, "127.0.0.2", 3), config.maxConnectionsPerIpOverrides)

chia7712 · 2026-03-20T05:47:13Z

+        return getInt(ServerLogConfigs.NUM_PARTITIONS_CONFIG);
+    }
+
+    public Integer logSegmentBytes() {


Should we return int instead of Integer here? IIRC, this config has a default value defined in ConfigDef, so it won't be null

I did this boxing (and the other ones you pointed out) to satisfy the compiler's the result type of an implicit conversion must be more specific than Object in KafkaConfig. If you swap this to int you should be able to see what I mean 😊. Once everything is in Java, I believe we ought to be able to revert back to primitive types.

> Task :core:compileScala [Error] /home/chia7712/project/kafka/core/src/main/scala/kafka/server/KafkaConfig.scala:580:52: the result type of an implicit conversion must be more specific than Object one error found

you are right 😢

chia7712 · 2026-03-20T05:47:17Z

+        return getInt(ServerLogConfigs.LOG_SEGMENT_BYTES_CONFIG);
+    }
+
+    public Long logFlushIntervalMessages() {


chia7712 · 2026-03-20T05:52:03Z

+        return getInt(SocketServerConfigs.MAX_CONNECTIONS_PER_IP_CONFIG);
+    }
+
+    public Map<String, Integer> maxConnectionsPerIpOverrides() {


We could leverage lambda style.

public Map<String, Integer> maxConnectionsPerIpOverrides() { return getMap(SocketServerConfigs.MAX_CONNECTIONS_PER_IP_OVERRIDES_CONFIG, getString(SocketServerConfigs.MAX_CONNECTIONS_PER_IP_OVERRIDES_CONFIG)) .entrySet() .stream() .collect(Collectors.toUnmodifiableMap(Map.Entry::getKey, e -> Integer.parseInt(e.getValue()))); }

chia7712 · 2026-03-20T05:56:05Z

+     * @return the type if found, or empty
+     */
+    public static Optional<ConfigDef.Type> configTypeExact(String exactName) {
+        Optional<ConfigDef.Type> t = configDefTypeOf(exactName);


we could refactor configTypeExact, configType, and configType

public static Optional<ConfigDef.Type> configDefTypeOf(String name) { return Optional.ofNullable(CONFIG_DEF.configKeys().get(name)) .map(key -> key.type); } public static Optional<ConfigDef.Type> configType(String configName) { return configDefTypeOf(configName) .or(() -> Optional.ofNullable(DynamicConfig.Broker.configKeys().get(configName)) .map(key -> key.type)) .or(() -> DynamicBrokerConfig.brokerConfigSynonyms(configName, true) .stream() .map(AbstractKafkaConfig::configDefTypeOf) .flatMap(Optional::stream) .findFirst()); }

chia7712 · 2026-03-24T00:46:30Z

 import java.util.Set;
 import java.util.stream.Collectors;

+import static org.apache.kafka.common.config.ConfigResource.Type.BROKER;


this is unnecessary

chia7712 · 2026-03-24T00:50:46Z

+    public Long logRollTimeJitterMillis() {
+        Long millis = getLong(ServerLogConfigs.LOG_ROLL_TIME_JITTER_MILLIS_CONFIG);
+        if (millis != null) return millis;
+        return 60L * 60L * 1000L * getInt(ServerLogConfigs.LOG_ROLL_TIME_JITTER_HOURS_CONFIG);


Maybe we could use TimeUnit instead?

return TimeUnit.HOURS.toMillis(getInt(ServerLogConfigs.LOG_ROLL_TIME_JITTER_HOURS_CONFIG));

chia7712 · 2026-03-24T00:52:40Z

+        return getLong(ServerLogConfigs.LOG_DIR_FAILURE_TIMEOUT_MS_CONFIG);
+    }
+
+    public Long logRetentionTimeMillis() {


public Long logRetentionTimeMillis() { Long millis = getLong(ServerLogConfigs.LOG_RETENTION_TIME_MILLIS_CONFIG); if (millis == null) { Integer mins = getInt(ServerLogConfigs.LOG_RETENTION_TIME_MINUTES_CONFIG); if (mins != null) { millis = TimeUnit.MINUTES.toMillis(mins); } else { millis = TimeUnit.HOURS.toMillis(getInt(ServerLogConfigs.LOG_RETENTION_TIME_HOURS_CONFIG)); } } return millis < 0 ? -1L : millis; }

For this one, I have changed to use TimeUnit, but the last line needs to be return millis < 0 ? Long.valueOf(-1) : millis;. Otherwise spotbugs complains with

Boxed value is unboxed and then immediately reboxed in org.apache.kafka.server.config.AbstractKafkaConfig.logRetentionTimeMillis()

This is one of those boxing/unboxing issues which ought to disappear once we move fully to Java

chia7712 · 2026-03-27T02:14:55Z


  @volatile private var defaultMaxConnectionsPerIp: Int = config.maxConnectionsPerIp
-  @volatile private var maxConnectionsPerIpOverrides = config.maxConnectionsPerIpOverrides.map { case (host, count) => (InetAddress.getByName(host), count) }
+  @volatile private var maxConnectionsPerIpOverrides = config.maxConnectionsPerIpOverrides.asScala.map { case (host, count) => (InetAddress.getByName(host), count.intValue()) }.toMap


It might be better to use a Java Map for maxConnectionsPerIpOverrides, but it's a minor nitpick. Happy to leave it for a follow-up

…to AbstractKafkaConfig (apache#21548) This is a gradual migration of KafkaConfig to Java for easier reviews. Moved the static methods to AbstractKafkaConfig and the methods used to access SocketServer and Log configs. Reviewers: Chia-Ping Tsai <chia7712@gmail.com>

github-actions Bot added triage PRs from the community core Kafka Broker labels Feb 23, 2026

github-actions Bot added the needs-attention label Mar 3, 2026

chia7712 reviewed Mar 5, 2026

View reviewed changes

Comment thread server/src/main/java/org/apache/kafka/server/config/AbstractKafkaConfig.java Outdated

github-actions Bot removed needs-attention triage PRs from the community labels Mar 6, 2026

clolov added 2 commits March 18, 2026 13:36

KAFKA-15853: Move static methods and SocketServer configs to Abstract…

7bb3dc2

…KafkaConfig

KAFKA-15853: Move Log configs to AbstractKafkaConfig

91504d9

clolov force-pushed the kafka-15853-draft branch from 14e269d to 91504d9 Compare March 18, 2026 13:56

Address Chia-Ping's comment

54d6e44

clolov changed the title ~~KAFKA-15853: Move static methods and SocketServer configs to AbstractKafkaConfig~~ KAFKA-15853: [1/N] Move static methods, SocketServer and Log configs to AbstractKafkaConfig Mar 18, 2026

clolov marked this pull request as ready for review March 18, 2026 14:01

Address spotbugs BX_UNBOXING_IMMEDIATELY_REBOXED

ca59550

Fix failing test

72bdc4f

chia7712 reviewed Mar 20, 2026

View reviewed changes

Address Chia-Ping's comments

d71a85c

chia7712 reviewed Mar 24, 2026

View reviewed changes

Address Chia-Ping's comments

691139c

chia7712 approved these changes Mar 27, 2026

View reviewed changes

chia7712 reviewed Mar 27, 2026

View reviewed changes

chia7712 merged commit 58b56c2 into apache:trunk Mar 27, 2026
24 checks passed

Conversation

clolov commented Feb 23, 2026 • edited by chia7712 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

UladzislauBlok commented Feb 25, 2026

Uh oh!

github-actions Bot commented Mar 3, 2026

Uh oh!

Uh oh!

chia7712 commented Mar 19, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

clolov commented Feb 23, 2026 •

edited by chia7712

Loading