Java 21: virtual threads for sampler execution + API migration#6685
Open
olka wants to merge 1 commit intoapache:masterfrom
Open
Java 21: virtual threads for sampler execution + API migration#6685olka wants to merge 1 commit intoapache:masterfrom
olka wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ThreadGroupnow usesThread.ofVirtual()for sampler threads and thread starters, reducing OS thread creation by ~3.5x (65 vs 226 thread creates for 200 concurrent users)synchronized→ReentrantLockconversions inStandardJMeterEngine,ThreadGroup,JMeterContextService,TestCompiler,AbstractThreadGroupto avoid virtual thread carrier pinningnew URL()→URI.create().toURL()in test code,@SuppressWarningsfor production code where URI is too strict,new Locale()→Locale.of(),Thread.getId()→threadId(), removed deprecatedThreadDeath/System.runFinalization()usageDesign decision
StandardJMeterEngine.EXECUTOR_SERVICEusesThread.ofPlatform()(not virtual) — virtual threads are daemon threads and would cause immediate JVM exit in non-GUI mode. Sampler threads remain virtual, tracked viawaitThreadsStopped().A/B Test Results (200 threads, 180s, 30ms server delay)
Test plan
./gradlew check— all tests pass (only pre-existingbatchFTP_TESTSexternal dependency failure)