Enhance HC4CookieHandler to Support Multiple Cookies with Individual Expiry Times#6458
Open
rahulkotha07 wants to merge 3 commits intoapache:masterfrom
Open
Enhance HC4CookieHandler to Support Multiple Cookies with Individual Expiry Times#6458rahulkotha07 wants to merge 3 commits intoapache:masterfrom
rahulkotha07 wants to merge 3 commits intoapache:masterfrom
Conversation
…individual expiry times Introduced HC4Cookie utility to support issuing and managing multiple cookies, each with its own expiry time (Max-Age). Updated HC4CookieHandler to correctly remove cookies from the response once their Max-Age is hit, ensuring a new cookie is issued in subsequent requests. Key changes: - Created HC4Cookie.java to encapsulate cookie creation logic with customizable Max-Age. - Ensures expired cookies are removed automatically and new ones are issued on next request. This provides better control and flexibility for testing real-world cookie management scenarios.
Update HC4CookieHandler.java handler to manage multiple cookies with …
Collaborator
|
Would you please add a test case for the change? |
Added Test for HC4CookieHandler to Support Multiple Cookies with Individual Expiry Times
Author
|
Sure, I have added the Unit test case now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change enhances the HC4CookieHandler.java to support handling multiple cookies, each with its own configurable expiry time (via Max-Age).
It ensures cookies are properly invalidated and removed after expiry so that new cookies are issued on subsequent requests.
Motivation and Context
The original implementation supported a single cookie with expiry. This enhancement allows testing of multiple cookie scenarios with different lifetimes, which is critical for applications simulating real-world session behavior or user tracking.
It helps validate cookie expiration handling in downstream systems using Apache JMeter’s HTTP components.
How Has This Been Tested?
Manual testing via a custom Spring Boot application that sets multiple cookies with varying Max-Age values.
JMeter was used to trigger requests and verify that cookies expired and were reissued correctly.
Verified cookie storage and expiry via debug logs and inspection of request headers.
Screenshots (if appropriate):
Types of changes
Checklist: