OAK-12145 : add compatibility tests for Caffeine migration (PR 2807)#2811
Open
rishabhdaim wants to merge 5 commits intotrunkfrom
Open
OAK-12145 : add compatibility tests for Caffeine migration (PR 2807)#2811rishabhdaim wants to merge 5 commits intotrunkfrom
rishabhdaim wants to merge 5 commits intotrunkfrom
Conversation
Add implementation-independent test coverage for all classes affected by the Guava-to-Caffeine cache migration in OAK-11946. Tests reference only Oak-level types (CacheLIRS, CacheStats, DiffCache, etc.) so the same suite can be cherry-picked to OAK-11946 and run unchanged; any failure there is a migration compatibility gap. Modules covered: - oak-core-spi: AbstractCacheStats, CacheLIRS, EmpiricalWeigher - oak-store-document: DocumentNodeStoreBuilder, NodeDocumentCache, MemoryDiffCache, LocalDiffCache, TieredDiffCache, CachingCommitValueResolver, DocumentNodeStore, PersistentCache - oak-run-commons: DocumentNodeStoreHelper - oak-search: ExtractedTextCache (stats tracking) - oak-search-elastic: ElasticIndexStatistics (cache, refresh, failure) - oak-segment-tar: SegmentCache (loader failure contract) - oak-blob: BlobIdSet (cache miss / persistence semantics) - oak-blob-cloud: S3Backend (expiry, cache enable/disable) - oak-blob-cloud-azure: AzureBlobStoreBackend, AzureBlobStoreBackendV8 (expiry, cache enable/disable)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds implementation-independent compatibility tests for every class touched by the Guava-to-Caffeine cache migration in OAK-11946 / PR #2807.
All new tests reference only Oak-level types (
CacheLIRS,CacheStats,DiffCache, etc.) — no direct imports oforg.apache.jackrabbit.guava.common.cache.*orcom.github.benmanes.caffeine.cache.*. The same test suite can be cherry-picked onto OAK-11946 and run unchanged; any failure there is a migration compatibility gap, not a test defect.Changes
oak-core-spiAbstractCacheStatsTest,CacheLIRSCompatibilityTest,EmpiricalWeigherTestoak-store-documentDocumentNodeStoreBuilderTest,NodeDocumentCacheTest,MemoryDiffCacheTest,TieredDiffCacheTest,LocalDiffCacheCompatibilityTest,PersistentCacheCompatibilityTest,CommitValueResolverTest,DocumentNodeStoreTestoak-run-commonsDocumentNodeStoreHelperTestgetNodesCachereturn type andasMapcontractoak-searchExtractedTextCacheTestoak-search-elasticElasticIndexStatisticsCompatibilityTestoak-segment-tarSegmentCacheTestExecutionExceptionoak-blobBlobIdSetCompatibilityTestoak-blob-cloudS3BackendTestoak-blob-cloud-azureAzureBlobStoreBackendCompatibilityTest,AzureBlobStoreBackendV8TestTest Plan
Links