Skip to content

Fix that WALBuffer waits for flush instead of file-roll #17628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jt2594838 wants to merge 4 commits into
base: master
Choose a base branch
from

fix import

44d3b74
Select commit
Loading
Failed to load commit list.
Open

Fix that WALBuffer waits for flush instead of file-roll #17628

fix import
44d3b74
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed May 9, 2026 in 2m 34s

Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 172 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/buffer/WALBuffer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Distance between variable 'file' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4MWO9DJxyiBuPnoZZo&open=AZ4MWO9DJxyiBuPnoZZo&pullRequest=17628

Check warning on line 620 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/node/WALNode.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 122 to 64, Complexity from 24 to 14, Nesting Level from 6 to 2, Number of Variables from 12 to 6. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4MWPOPJxyiBuPnoZZp&open=AZ4MWPOPJxyiBuPnoZZp&pullRequest=17628

Check failure on line 681 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/buffer/WALBuffer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this call to "await" or move it into a "while" loop. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4MWO9DJxyiBuPnoZZm&open=AZ4MWO9DJxyiBuPnoZZm&pullRequest=17628

Check failure on line 692 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/buffer/WALBuffer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this call to "await" or move it into a "while" loop. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4MWO9DJxyiBuPnoZZn&open=AZ4MWO9DJxyiBuPnoZZn&pullRequest=17628
View more details on SonarQubeCloud