Move TableScaNode to node-commons#17627
Open
Wei-hao-Li wants to merge 5 commits intomasterfrom
Open
Conversation
shuwenwei
reviewed
May 9, 2026
| public <R, C> R accept(IPlanVisitor<R, C> visitor, C context) { | ||
| return ((PlanVisitor<R, C>) visitor).visitTableScan(this, context); |
Member
There was a problem hiding this comment.
visitTableScan should not stay in datanode PlanVisitor after TableScanNode is moved to node-commons
Wei-hao-Li
changed the title
|
shuwenwei
approved these changes
May 9, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #17627 +/- ##
=========================================
Coverage 40.23% 40.23%
Complexity 2554 2554
=========================================
Files 5177 5177
Lines 348880 348858 -22
Branches 44624 44625 +1
=========================================
+ Hits 140363 140368 +5
+ Misses 208517 208490 -27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.