Fix: add @deprecated Javadoc and handle deprecated method properly#17331
Open
A0R0P0I7T wants to merge 2 commits intoapache:masterfrom
Open
Fix: add @deprecated Javadoc and handle deprecated method properly#17331A0R0P0I7T wants to merge 2 commits intoapache:masterfrom
A0R0P0I7T wants to merge 2 commits intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes SonarCloud issues in the MQTT example module related to deprecated method handling and missing Javadoc.
The deprecated method
format(ByteBuf payload)previously threw aNotImplementedException. It is now updated to delegate toformat(String topic, ByteBuf payload)to ensure backward compatibility.Additionally, the missing
@deprecatedJavadoc tag has been added to align with SonarCloud rules.Changes
@deprecatedJavadoc tag to deprecated methodNotImplementedExceptionwith delegation to the newer methodNotImplementedExceptionMotivation
Fix SonarCloud issues:
SonarCloud links:
Verification
mvn spotless:applymvn clean install -DskipTestsChecklist
Files Modified
example/mqtt-customize/src/main/java/org/apache/iotdb/mqtt/server/CustomizedJsonPayloadFormatter.java