Skip to content

Conversation

@CRZbulabula
Copy link
Contributor

This PR aims to close issue #17030.

We found that our partition table is cleaned incorrectly when set only device TTL for tree mode. In fact, the old data partitions could be deleted if and only if:

The corresponding database has set a database-level TTL.
The data partition is existed longer than the maximum TTL among all defined TTL under the corresponding database.
To avoid this fatal bug occurs again, we also append a CI for this case.

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Jan 31, 2026

Codecov Report

❌ Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.31%. Comparing base (0861162) to head (7329ae5).
⚠️ Report is 1 commits behind head on dev/1.3.

Files with missing lines Patch % Lines
.../org/apache/iotdb/commons/schema/ttl/TTLCache.java 0.00% 12 Missing ⚠️
...rg/apache/iotdb/confignode/manager/TTLManager.java 0.00% 5 Missing ⚠️
...g/apache/iotdb/confignode/persistence/TTLInfo.java 0.00% 5 Missing ⚠️
...onfignode/procedure/PartitionTableAutoCleaner.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev/1.3   #17126      +/-   ##
=============================================
- Coverage      41.32%   41.31%   -0.02%     
  Complexity       198      198              
=============================================
  Files           3595     3595              
  Lines         236250   236274      +24     
  Branches       28585    28590       +5     
=============================================
- Hits           97634    97620      -14     
- Misses        138616   138654      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@CRZbulabula CRZbulabula merged commit 230e3a8 into dev/1.3 Jan 31, 2026
20 of 21 checks passed
@CRZbulabula CRZbulabula deleted the partition-bug-fix branch January 31, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants