fix(devcontainer): make Config UI and Grafana accessible from host when using devcontainers#8645
Open
amnir wants to merge 2 commits intoapache:mainfrom
Open
fix(devcontainer): make Config UI and Grafana accessible from host when using devcontainers#8645amnir wants to merge 2 commits intoapache:mainfrom
amnir wants to merge 2 commits intoapache:mainfrom
Conversation
dosubot
bot
added
size:S
…ontainer when started by listening on 0.0.0.0 with the `--host` flag. Also ensure it uses port 4000 or fails to start with `--strictPort` to prevent silent port change that will mismatch with the exported dev container port.
amnir
force-pushed
the
fix-devcontainer
branch
from
3396b54 to
d3d8d99
Compare
…en using devcontainers
amnir
force-pushed
the
fix-devcontainer
branch
from
d3d8d99 to
8fac702
Compare
Author
|
@rbstp Could you please re-run the checks? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make config-ui dev server accessible outside the container when started by listening on 0.0.0.0 with the --host flag.
Also ensure it uses port 4000 or fails to start with --strictPort to prevent silent port change that will mismatch with the exported dev container port.
In addition, it makes Grafana accessible from dev container' config-ui by making the Grafana origin and origin change configurable and injected via the dev container environment variables.
web socket proxying (ws) is enabled regardless of dev container or not as it allows for features like grafana query auto-complete to work via the dev server proxy.
Does this close any open issues?
Closes #8638
Other Information
Re-opened as a new PR to better comply with the contribution guidelines (branch name + commit message)
(Initial PR)