Skip to content

Conversation

@jinxxxoid
Copy link
Contributor

Thank you for submitting the pull request.

To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:

The Review Checklist

  • Formal criteria: TC status, codestyle, mandatory documentation. Also make sure to complete the following:
    - There is a single JIRA ticket related to the pull request.
    - The web-link to the pull request is attached to the JIRA ticket.
    - The JIRA ticket has the Patch Available state.
    - The description of the JIRA ticket explains WHAT was made, WHY and HOW.
    - The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • Design: new code conforms with the design principles of the components it is added to.
  • Patch quality: patch cannot be split into smaller pieces, its size must be reasonable.
  • Code quality: code is clean and readable, necessary developer documentation is added if needed.
  • Tests code quality: test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.

Notes

jinxxxoid added 30 commits July 22, 2025 12:52
Comment on lines 144 to 153
| DirtyPages | Current number of dirty pages in memory.
| LastEstimatedSpeedForMarkAll | The last estimated speed of marking all clean pages dirty to the end of a checkpoint, in pages per second.
| LoadedPages | Current number of pages loaded in memory.
| MaxSize | The maximum in-memory region size in bytes.
| MarkDirtySpeed | The speed of marking pages dirty, in pages per second. The value is averaged over the last 3 fragments, 0.25 sec each, plus the current fragment, 0–0.25 sec (0.75–1.0 sec total).
| PageReplacements | Number of times a page was replaced (evicted) from the page cache.
| PageCacheHits | Number of times a page was found in the page cache.
| PageCacheMisses | Number of times a page was not found in the page cache and had to be loaded from disk.
| PageCacheHitRate | Page cache hit rate over the last 5 minutes.
| PageAcquireTime | Distribution of page acquisition time in nanoseconds.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its probably an accident that this PR includes changes from #7397

@jinxxxoid jinxxxoid requested a review from dant3 January 13, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants