feat(go): implement TCP/TLS connection in Go SDK#2834
Open
saie-ch wants to merge 2 commits intoapache:masterfrom
Open
feat(go): implement TCP/TLS connection in Go SDK#2834saie-ch wants to merge 2 commits intoapache:masterfrom
saie-ch wants to merge 2 commits intoapache:masterfrom
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #2834 +/- ##
============================================
- Coverage 67.58% 67.55% -0.04%
Complexity 708 708
============================================
Files 1027 1027
Lines 83147 83188 +41
Branches 60004 60004
============================================
Hits 56195 56195
- Misses 24612 24653 +41
Partials 2340 2340
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This unblocks issue #2807 so TCP/TLS integration tests and examples can now be written for the Go
SDK.
Rationale
The Go SDK had TLS configuration fields (tlsEnabled, tlsDomain, tlsCAFile, tlsValidateCertificate)
and TLS error types generated, but the handshake was stubbed out at line 329 with return
errors.New("TLS connection is not implemented yet"). This blocked writing integration tests and
examples for TCP/TLS connections.
What changed?
Before: Line 329 returned a stub error preventing any TLS connections.
After: Full TLS implementation with:
WithTLSValidateCertificate()
ErrInvalidTlsCertificate)
Implementation follows the same patterns as Rust (tcp_tls_connection_stream.rs), Java
(InternalTcpClient.java), C# (TcpMessageStream.cs), and Node.js (client.connection.ts) SDKs.
AI Usage
Claude Sonnet 4.5