feat(csharp): add TCP/TLS producer and consumer examples#2821
feat(csharp): add TCP/TLS producer and consumer examples#2821atharvalade wants to merge 2 commits intoapache:masterfrom
Conversation
|
Resolved |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2821 +/- ##
============================================
- Coverage 71.44% 71.43% -0.02%
Complexity 708 708
============================================
Files 969 969
Lines 78219 78219
Branches 60029 60039 +10
============================================
- Hits 55884 55874 -10
Misses 20002 20002
- Partials 2333 2343 +10
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Configure IggyClientConfigurator with TlsSettings using custom CA certs
d33f1d0 to
3bb3a69
Compare
mmodzelewski
left a comment
There was a problem hiding this comment.
@atharvalade same as with Java PR, the examples should be included in the README.
@lukaszzborek please have a look when you can.
lukaszzborek
left a comment
There was a problem hiding this comment.
Overall looks good, but 2 points
- add this example into README file in examples/csharp directory to be run by CI
- iggy server used by this example not use tls in configuration. Propably we need to run second instance in script with different configuration with tls (need to be check)
@hubcio
|
@lukaszzborek this will not be that simple because we'd have to restart server - there is either normal unencrypted TCP or TLS TCP. I'd say that we create separate instance for server for TLS tests. @atharvalade can you figure it out? see scripts/run-csharp-examples-from-readme.sh |
give me some time, I'll look into this. |
Which issue does this PR close?
Closes #2806
Rationale
The C# SDK had comprehensive TLS integration tests but no TLS examples in
examples/csharp/for users to reference.What changed?
Users had to read the integration test source to understand TLS configuration despite the SDK having full TLS support via
TlsSettings.Added
TcpTlsexample projects with producer and consumer demonstratingIggyClientConfiguratorwithTlsSettings(Enabled, Hostname, CertificatePath) pointing tocore/certs/iggy_ca_cert.pem. Registered new projects inIggy_SDK.Examples.slnunder a TcpTls solution folder.Local Execution
Passed.
dotnet build Iggy_SDK.Examples.slnsucceeds with 0 warnings, 0 errors.AI Usage
GettingStartedexamples andIggyTlsConnectionTests.csTLS config patterns