Spark: Add regression test for MERGE struct nullification#16326
Open
yadavay-amzn wants to merge 1 commit into
Open
Spark: Add regression test for MERGE struct nullification#16326yadavay-amzn wants to merge 1 commit into
yadavay-amzn wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16246.
Summary
Adds a regression test verifying that MERGE INTO preserves non-nullable children of a nullable struct column when updating other columns.
Context
Issue #16246 reported that MERGE INTO silently nullified non-nullable struct children on Iceberg 1.5.2 / Spark 3.3. The bug is already fixed on main (likely resolved by schema handling improvements in later versions). This test prevents reintroduction.
Test
testMergePreservesNullableStructWithRequiredChildren:id INT, status STRING, info STRUCT<type:STRING NOT NULL, attr:STRING NOT NULL>statuscolumn