Aliyun/Dell: Classify missing object reads as NotFoundException#16300
Open
atovk wants to merge 1 commit into
Open
Aliyun/Dell: Classify missing object reads as NotFoundException#16300atovk wants to merge 1 commit into
atovk wants to merge 1 commit into
Conversation
Aliyun OSS and Dell ECS stream reads were leaking provider-specific missing-object exceptions, unlike S3, ADLS, GCS, and Hadoop. The metastore refresh path stops retries on Iceberg NotFoundException, so stale metadata locations could retry a permanent missing-object condition until the retry budget is exhausted. This keeps the storage-specific exists behavior and translates missing-object errors at the read boundary to NotFoundException. Non-not-found provider errors are preserved. Constraint: BaseMetastoreTableOperations stops metadata refresh retries on NotFoundException Rejected: Add an exists probe before every metadata read | adds an extra object-store request and duplicates behavior expected of FileIO read paths Confidence: high Scope-risk: narrow Reversibility: clean Directive: New FileIO read paths should classify permanent not-found conditions as NotFoundException Tested: JAVA_HOME=/Users/nullwo/.gradle/jdks/amazon_com_inc_-17-aarch64-os_x/amazon-corretto-17.jdk/Contents/Home ./gradlew --no-daemon --max-workers=1 :iceberg-aliyun:check :iceberg-dell:check Related: apache#16299
atovk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NoSuchKey/NoSuchBucketstream-open failures to IcebergNotFoundExceptionreadObjectStreamfailures to IcebergNotFoundExceptionRoot cause
BaseMetastoreTableOperations.refreshFromMetadataLocationstops metadata read retries on IcebergNotFoundException. Aliyun OSS and Dell ECS already treat missing objects as absent inexists(), but their stream-read paths leaked provider SDK exceptions. A stale catalog metadata location could therefore retry a permanent missing-object failure instead of failing fast.Closes #16299.
Testing
JAVA_HOME=/Users/nullwo/.gradle/jdks/amazon_com_inc_-17-aarch64-os_x/amazon-corretto-17.jdk/Contents/Home ./gradlew --no-daemon --max-workers=1 :iceberg-aliyun:check :iceberg-dell:check