Core, Data, Spark: Moving Spark to use the new FormatModel API#15328
Core, Data, Spark: Moving Spark to use the new FormatModel API#15328pvary wants to merge 3 commits intoapache:mainfrom
Conversation
| return super.newPositionDeleteWriter(file, spec, partition); | ||
| } else { | ||
| LOG.info( | ||
| "Deprecated feature used. Position delete row schema is used to create the position delete writer."); |
There was a problem hiding this comment.
nit: should we mark this as @deprecated?
|
can we run the benchmarks for spark to see how the benchmarks turns out to be post these : https://github.com/apache/iceberg/tree/main/spark/v4.1/spark/src/jmh/java/org/apache/iceberg/spark ? |
Added some new tests for Parquet ( The differences are barely noticeable in any direction. There should not be any real difference as the resulting readers and writers are using the same code. |
Part of: #12298
Implementation of the new API: #12774
SparkFormatModel and related changes