Fix(site): improve homepage responsiveness on smaller screens#15266
Fix(site): improve homepage responsiveness on smaller screens#15266Prakash1185 wants to merge 1 commit intoapache:mainfrom
Conversation
|
Hi @nastra , @ajantha-bhat |
kevinjqliu
left a comment
There was a problem hiding this comment.
thanks for the PR! the site formatting on mobile has been an annoyance for me.
is there a way we can structure the changes here so that its more maintainable?
| max-width: 100%; | ||
| } | ||
|
|
||
| @media (max-width: 992px) { |
There was a problem hiding this comment.
these changes feel like "magic" to me. is there a more systemic approach to achieve the same result?
|
Thanks for the feedback @kevinjqliu. For this PR, I mainly used media queries targeting smaller breakpoints to address the layout issues along with some spacing adjustments. |
|
That would be great! Im not a frontend person at all, i think it would be easier for me to understand the code if its following a more systematic approach (if there are any) |
|
Sorry for the late reply. @kevinjqliu For now, this change fixes the issue using a mainly flexbox based approach, which is also a valid way to handle responsiveness. We can also try moving toward a more grid-based structure to simplify the layout and make it easier to follow. |
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
Problem
Changes
Screenshots