Parquet: Fix typo in BaseParquetReaders and BaseParquet…#15244
Open
HennesyChihiro wants to merge 1 commit intoapache:mainfrom
Open
Parquet: Fix typo in BaseParquetReaders and BaseParquet…#15244HennesyChihiro wants to merge 1 commit intoapache:mainfrom
HennesyChihiro wants to merge 1 commit intoapache:mainfrom
Conversation
nandorKollar
approved these changes
Feb 10, 2026
kevinjqliu
reviewed
Feb 15, 2026
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
thanks for the PR! a couple of comments
| public ParquetValueReader<?> struct( | ||
| Types.StructType expected, GroupType struct, List<ParquetValueReader<?>> fieldReaders) { | ||
| // the expected struct is ignored because nested fields are never found when the | ||
| // the expected struct is ignored because nested fields are never found when the ID is missing |
Contributor
There was a problem hiding this comment.
looks like there are a couple more instances of this
Contributor
There was a problem hiding this comment.
i asked claude to write a better comment, heres what it came up with. thoughts?
// Unlike ReadBuilder.struct(), this does not reorder fields to match the expected schema
// or handle missing fields with defaults. Without field IDs in the Parquet schema, fields
// cannot be matched by ID, so they are read in file order instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR cleans up documentation, fixes typos, and corrects inconsistent error messages in the Parquet data package, specifically within BaseParquetReaders and BaseParquetWriter.
Changes
BaseParquetWriter: Fixed an error message in the visit(IntLogicalTypeAnnotation) method where it incorrectly used "read" instead of "write" when handling uint64.
BaseParquetReaders: Completed an unfinished comment regarding missing nested field IDs and fixed minor typos.