Core: Adding additional information in RestException

[masfworld]

There are scenarios where there are RESTException issues but the message is providing value. For instance:

org.apache.iceberg.exceptions.RESTException: Unable to process: \n\tat
org.apache.iceberg.rest.ErrorHandlers$DefaultErrorHandler.accept(ErrorHandlers.java:250)\n\tat
org.apache.iceberg.rest.ErrorHandlers$TableErrorHandler.accept(ErrorHandlers.java:124)\n\tat
org.apache.iceberg.rest.ErrorHandlers$TableErrorHandler.accept(ErrorHandlers.java:108)\n\tat

So, the idea is to provide code and type in RESTException to get more context.

[singhpk234]

while we are here can we also add error code and type in

iceberg/core/src/main/java/org/apache/iceberg/rest/ErrorHandlers.java

Line 239 in 0651b89

throw new RESTException("Unable to process: %s", error.message());

[masfworld]

But here it's clear because this exception is triggered when the code is 422, which is Unprocessable Entity, then the current message for me is enough.

[singhpk234]

IMHO its more about consistency than enhancing, for example we can say all the rest exception follow this pattern, since we don't have defined exception for it, it would be great to have this consistently have an error message format, WDYT ?

[singhpk234]

i wonder if making the null as unknown adds more value ? how about just having error.type() ?

[masfworld]

Agree