Core: Cleaning up uncommitted cleanup logic in SnapshotProducer implementations #14923
+34
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dramaticlly
approved these changes
Dec 23, 2025
Contributor
dramaticlly
left a comment
dramaticlly
left a comment
There was a problem hiding this comment.
Cleanup LGTM but there's opportunity for a bit more
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java
Outdated
Show resolved
Hide resolved
amogh-jahagirdar
force-pushed
the
msp-refactoring
branch
from
9a4aca5 to
c143096
Compare
geruh
reviewed
Dec 23, 2025
amogh-jahagirdar
force-pushed
the
msp-refactoring
branch
from
c143096 to
3205ee3
Compare
amogh-jahagirdar
force-pushed
the
msp-refactoring
branch
from
3205ee3 to
804fde5
Compare
amogh-jahagirdar
changed the title
singhpk234
approved these changes
Dec 24, 2025
Contributor
singhpk234
left a comment
singhpk234
left a comment
There was a problem hiding this comment.
LGTM, thanks @amogh-jahagirdar !
huaxingao
approved these changes
Dec 24, 2025
Contributor
|
Thanks @amogh-jahagirdar for the PR! Thanks @dramaticlly @geruh @singhpk234 for the review! |
stuxuhai
pushed a commit
to stuxuhai/iceberg
that referenced
this pull request
Dec 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was going through MergingSnapshotProducer code and noticed that there's a bit of redundancy in the cleanUncommittedAppends logic, so did a refactoring there. Also cleaned up the preconditions check for format 3 and 4 for delete files, since it's the same condition, we can collapse those cases.